Apache Tomcat Maven Plugin :: Common API

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
13	0	75	11

Files

Files	W	E
org/apache/tomcat/maven/common/config/AbstractWebapp.java	20	0
org/apache/tomcat/maven/common/deployer/TomcatManager.java	13	6
org/apache/tomcat/maven/common/deployer/TomcatManagerResponse.java	10	1
org/apache/tomcat/maven/common/messages/DefaultMessagesProvider.java	2	0
org/apache/tomcat/maven/common/messages/MessagesProvider.java	4	0
org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java	1	2
org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java	15	1
org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorResult.java	5	1
org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java	2	0
org/apache/tomcat/maven/common/run/ExternalRepositoriesReloadableWebappLoader.java	2	0
org/apache/tomcat/maven/common/run/TomcatRunException.java	1	0

Rules

Rules	Violations	Severity
FileLength	0	Error
RegexpHeader headerFile: `"target/checkstyle-header.txt"`	3	Error
FileTabCharacter eachLine: `"true"`	0	Error
LeftCurly option: `"nl"`	0	Error
RightCurly option: `"alone"`	0	Error
LineLength max: `"120"` ignorePattern: `"@version\|@see\|@todo\|TODO"`	2	Error
MemberName	0	Error
JavadocMethod scope: `"protected"`	64	Warning
JavadocType allowUnknownTags: `"true"` scope: `"protected"`	0	Error
JavadocVariable scope: `"protected"`	0	Info
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	1	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad option: `"space"`	0	Error
OperatorWrap	0	Error
ParenPad option: `"space"`	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	0	Error
ModifierOrder	1	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock option: `"text"`	0	Error
NeedBraces	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	11	Warning
IllegalInstantiation	0	Error
InnerAssignment	1	Error
MagicNumber ignoreNumbers: `"-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"`	1	Error
MissingSwitchDefault	1	Error
RedundantThrows	1	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
InterfaceIsType	0	Error
VisibilityModifier packageAllowed: `"true"` protectedAllowed: `"true"`	0	Error
UpperEll	0	Error

Details

org/apache/tomcat/maven/common/config/AbstractWebapp.java

Violation	Message	Line
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	94
	Missing a Javadoc comment.	99
	Missing a Javadoc comment.	104
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	114
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	124
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	134
	Missing a Javadoc comment.	143
	Missing a Javadoc comment.	148
	Missing a Javadoc comment.	153
	Missing a Javadoc comment.	158
	Missing a Javadoc comment.	163
	Missing a Javadoc comment.	168
	Missing a Javadoc comment.	173

org/apache/tomcat/maven/common/deployer/TomcatManager.java

Violation	Message	Line
	Expected an @return tag.	364
	Expected @param tag for 'path'.	364
	Expected @param tag for 'war'.	364
	Expected @param tag for 'update'.	364
	Expected @param tag for 'tag'.	364
	Expected @param tag for 'length'.	364
	Expected @throws tag for 'TomcatManagerException'.	365
	Expected @throws tag for 'IOException'.	365
	Expected @param tag for 'length'.	697
	switch without "default" clause.	725
	Line is longer than 120 characters.	732
	Missing a Javadoc comment.	747
	'username' hides a field.	763
	'password' hides a field.	763
	'static' modifier out of order with the JLS suggestions.	778
	Redundant throws: 'IllegalStateException' is unchecked exception.	806
	Inner assignments should be avoided.	838
	'url' hides a field.	877
	'1023' is a magic number.	939

org/apache/tomcat/maven/common/deployer/TomcatManagerResponse.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	43
	'statusCode' hides a field.	43
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	54
	'reasonPhrase' hides a field.	54
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	65
	'httpResponseBody' hides a field.	65

org/apache/tomcat/maven/common/messages/DefaultMessagesProvider.java

Violation	Message	Line
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	51

org/apache/tomcat/maven/common/messages/MessagesProvider.java

Violation	Message	Line
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36

org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java

Violation	Message	Line
	Unused import - java.util.List.	22
	Line is longer than 120 characters.	30
	Missing a Javadoc comment.	30

org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	48
	'mavenProject' hides a field.	48
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	59
	'dependencies' hides a field.	59
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	70
	'log' hides a field.	70
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	81
	'addWarDependenciesInClassloader' hides a field.	82
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	93
	'useTestClassPath' hides a field.	93

org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorResult.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	61

org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

Violation	Message	Line
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	214

org/apache/tomcat/maven/common/run/ExternalRepositoriesReloadableWebappLoader.java

Violation	Message	Line
	Expected @param tag for 'log'.	64
	Expected an @return tag.	130

org/apache/tomcat/maven/common/run/TomcatRunException.java

Violation	Message	Line
	Missing a Javadoc comment.	29